Skip to content

Feature: Introduced Omnibar 1 #17023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

Feature: Introduced Omnibar 1 #17023

merged 4 commits into from
Apr 30, 2025
+607 −98

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 6, 2025 •
edited
Loading

Resolved / Related Issues

Introduced Omnibar and added support for the Path mode.

Steps used to test these changes

  1. Open Files app
  2. Enable Omnibar from Settings > Advanced
  3. Test the breadcrumb bar
    1. Click on a breadcrumb item
    2. Click on a breadcrumb item's chevron
    3. Click on a flyout item of a breadcrumb item's chevron
    4. Click on the root item (Home)
    5. Click on a flyout item of the root item's chevron
  4. Test the Omnibar's textbox
    1. Enter test and see the suggestions being updated
    2. Submit the entered text by tappping Enter key to see the navigation
  5. Test the Omnibar's focus

image

image

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch 4 times, most recently from f93960a to e1ee482 Compare April 10, 2025 02:54
yaira2
yaira2 reviewed Apr 10, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 10, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 21, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 21, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 21, 2025
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Apr 21, 2025

I found an issue where text entered into the address bar isn't cleared after removing the focus. The easiest way to test this is by removing the focus and then refocusing the address bar.

@0x5bfa 0x5bfa changed the title Feature: Introduced Omnibar Feature: Introduced Omnibar 1 Apr 22, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch 2 times, most recently from 0aeb079 to e4ba94d Compare April 22, 2025 09:16
yaira2
yaira2 reviewed Apr 22, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 22, 2025
View reviewed changes
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 75d29b5 to aa7d7fa Compare April 22, 2025 22:33
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from 35ce79a to dc2399d Compare April 23, 2025 01:52
yaira2
yaira2 reviewed Apr 23, 2025
View reviewed changes
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from 49fd456 to c93e9c0 Compare April 23, 2025 02:04
yaira2
yaira2 reviewed Apr 23, 2025
View reviewed changes
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from 4eef142 to b1b7ad5 Compare April 25, 2025 07:46
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from b1b7ad5 to 13e1f84 Compare April 27, 2025 12:41
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from fde064d to 6a80bcd Compare April 27, 2025 14:59
@Josh65-2201 Josh65-2201 mentioned this pull request Apr 28, 2025
Closed
yaira2
yaira2 reviewed Apr 29, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 29, 2025
View reviewed changes
yaira2
yaira2 reviewed Apr 29, 2025
View reviewed changes
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Apr 29, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from 479cb18 to b230228 Compare April 30, 2025 01:50
@0x5bfa @yaira2
Wrap up
e4c6ec1 
Co-Authored-By: Yair <[email protected]>
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarIntroduction branch from b230228 to e4c6ec1 Compare April 30, 2025 01:54
yaira2
yaira2 reviewed Apr 30, 2025
View reviewed changes
yaira2
yaira2 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see the Omnibar in action!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 30, 2025
@yaira2 yaira2 marked this pull request as ready for review April 30, 2025 14:39
@yaira2 yaira2 merged commit 25309d8 into files-community:main Apr 30, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-OmnibarIntroduction branch April 30, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x5bfa @yaira2